feat: add content tagging application #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
force-pushed
the
and/add_openedx_learning
branch
from
faeb545 to
5b2aced
Compare
andrey-canon
force-pushed
the
and/backport_tagging
branch
from
7e7c725 to
06e4a0c
Compare
andrey-canon
changed the base branch from
and/add_openedx_learning
to
and/backport_blockstore
andrey-canon
force-pushed
the
and/backport_tagging
branch
11 times, most recently
from
ff8045c to
8c770b5
Compare
andrey-canon
changed the base branch from
and/backport_blockstore
to
and/backport_authoring_event_signals
andrey-canon
force-pushed
the
and/backport_authoring_event_signals
branch
from
e3b48a0 to
82aa8d1
Compare
johanseto
approved these changes
May 7, 2024
There was a problem hiding this comment.
I was testing 2 main things. Content tagging code, and openedx-learning plugin.
- content tagging:
For content tagging, API, migrations, and admin seems working
- openedx-learning plugin
For openedx-learning package the admin,and migrations seems ok.
But now, I have a question do you know if openedx-learning API URL works.
Or that is unnecessary URLs data ?
https://github.com/openedx/openedx-learning/blob/main/openedx_tagging/core/tagging/urls.py
I say because there are views or endpoints...
That ones would be considered to check?
| @@ -3193,6 +3193,10 @@ def _make_locale_paths(settings): # pylint: disable=missing-function-docstring | |||
| # Course Goals | |||
| 'lms.djangoapps.course_goals.apps.CourseGoalsConfig', | |||
|
|
|||
| # Tagging | |||
| 'openedx_tagging.core.tagging.apps.TaggingConfig', | |||
There was a problem hiding this comment.
I didnt now where is tagging, now I now is part of openedx-learning wtf
andrey-canon
changed the base branch from
and/backport_authoring_event_signals
to
open-release/palm.nelp
commit taken from openedx#32907
andrey-canon
force-pushed
the
and/backport_tagging
branch
from
8c770b5 to
e9ac94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.